fix: reenable floating point exceptions #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrsettgast
added
ci: run CUDA builds
rrsettgast
requested review from
wrtobin,
sframba,
tbeltzun,
CusiniM and
herve-gross
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3300 +/- ##
========================================
Coverage 56.46% 56.46%
========================================
Files 1059 1059
Lines 89458 89465 +7
========================================
+ Hits 50512 50519 +7
Misses 38946 38946 ☔ View full report in Codecov by Sentry. |
rrsettgast
requested review from
paveltomin,
klevzoff,
francoishamon,
castelletto1 and
victorapm
as code owners
victorapm
approved these changes
Aug 23, 2024
paveltomin
approved these changes
Aug 23, 2024
rrsettgast
changed the title
rrsettgast
requested review from
corbett5,
dkachuma and
joshua-white
as code owners
CusiniM
approved these changes
Aug 26, 2024
…cannot reproduce the error except on a github hosted runner
…cannot reproduce the error except on a github hosted runner
wrtobin
approved these changes
Aug 28, 2024
wrtobin
reviewed
Aug 28, 2024
corbett5
approved these changes
Aug 28, 2024
rrsettgast
commented
Aug 28, 2024
…ate_poromechanics_1d_smoke_02,elas3D_Q3_abc_smoke_01,elas3D_Q3_abc_smoke_08,elas3D_Q3_abc_fs_smoke_01,elas3D_Q3_abc_fs_smoke_08
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
* reintroduce GEOS_ENABLE_FPE to GeosxOptions.cmake * give Compositional[/Well]MultiphaseBase::m_maxRelativeCompDensChange a usable default value * some modifications for fpe on testFlowStatistics * update TPL paths. more fixes for CO2SolubilityDuanSun.cpp * just disable FPE for testVTKImport * allow failure of SeismicityRate_poromechanics_1d_smoke_01,SeismicityRate_poromechanics_1d_smoke_02,elas3D_Q3_abc_smoke_01,elas3D_Q3_abc_smoke_08,elas3D_Q3_abc_fs_smoke_01,elas3D_Q3_abc_fs_smoke_08 which all generate FPE's
rrsettgast
added a commit
that referenced
this pull request
Sep 17, 2024
* reintroduce GEOS_ENABLE_FPE to GeosxOptions.cmake * give Compositional[/Well]MultiphaseBase::m_maxRelativeCompDensChange a usable default value * some modifications for fpe on testFlowStatistics * update TPL paths. more fixes for CO2SolubilityDuanSun.cpp * just disable FPE for testVTKImport * allow failure of SeismicityRate_poromechanics_1d_smoke_01,SeismicityRate_poromechanics_1d_smoke_02,elas3D_Q3_abc_smoke_01,elas3D_Q3_abc_smoke_08,elas3D_Q3_abc_fs_smoke_01,elas3D_Q3_abc_fs_smoke_08 which all generate FPE's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
GEOS-DEV/LvArray#327
GEOS-DEV/thirdPartyLibs#279
resolves #3281